Release deploys again when its tests were skipped on purpose
A skipped job skips every job that needs it, even through one that runs anyway: since auto-release passes tested=true, the tests job is skipped, build ran with always(), and deploy (no condition of its own) was skipped. v3.2.0 built and never went live. Deploy and IndexNow now run whenever the job before them succeeded.
This commit is contained in:
parent
91b2afe706
commit
d03dde6fcd
1 changed files with 4 additions and 1 deletions
5
.github/workflows/release.yml
vendored
5
.github/workflows/release.yml
vendored
|
|
@ -125,8 +125,11 @@ jobs:
|
|||
with:
|
||||
path: ./_site
|
||||
|
||||
# A skipped job skips everything that needs it, even through build (which runs anyway): without always() here, a
|
||||
# release whose tests auto-release.yml already ran built and never deployed (v3.2.0).
|
||||
deploy:
|
||||
needs: build
|
||||
if: ${{ always() && needs.build.result == 'success' }}
|
||||
runs-on: ubuntu-latest
|
||||
permissions:
|
||||
pages: write
|
||||
|
|
@ -140,7 +143,7 @@ jobs:
|
|||
# the site is live.
|
||||
indexnow:
|
||||
needs: deploy
|
||||
if: ${{ !inputs.weekly }}
|
||||
if: ${{ always() && needs.deploy.result == 'success' && !inputs.weekly }}
|
||||
runs-on: ubuntu-latest
|
||||
env:
|
||||
# IndexNow keys are public by design (also served at /<key>.txt).
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue