From d03dde6fcd5089eb7bdeb1e73953ffa36e9b1074 Mon Sep 17 00:00:00 2001 From: Frederic Jung Date: Sat, 7 Nov 2026 14:38:19 +0100 Subject: [PATCH] Release deploys again when its tests were skipped on purpose A skipped job skips every job that needs it, even through one that runs anyway: since auto-release passes tested=true, the tests job is skipped, build ran with always(), and deploy (no condition of its own) was skipped. v3.2.0 built and never went live. Deploy and IndexNow now run whenever the job before them succeeded. --- .github/workflows/release.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 9c2defa..213596f 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -125,8 +125,11 @@ jobs: with: path: ./_site + # A skipped job skips everything that needs it, even through build (which runs anyway): without always() here, a + # release whose tests auto-release.yml already ran built and never deployed (v3.2.0). deploy: needs: build + if: ${{ always() && needs.build.result == 'success' }} runs-on: ubuntu-latest permissions: pages: write @@ -140,7 +143,7 @@ jobs: # the site is live. indexnow: needs: deploy - if: ${{ !inputs.weekly }} + if: ${{ always() && needs.deploy.result == 'success' && !inputs.weekly }} runs-on: ubuntu-latest env: # IndexNow keys are public by design (also served at /.txt).