seriesoftubes/tests/route-cache.test.js
Frederic Jung d6b08dded3
Kept exit orders also check each exit's kind
An exit that turned from an exchange into a PNI at the same place in the list, city and
preference kept the order made for the exchange, which sorts behind a PNI at the same
distance, so the cached routing could differ from routing without the cache (#320 review).
The exit signature now includes the kind. Also drops the unused e.vis.
2026-11-09 10:40:39 +00:00

146 lines
8.8 KiB
JavaScript

// What compute() keeps between calls (src/game/80-simulation/29-route-cache.js): the shortest paths and the exit lists,
// rebuilt only when their key changes. These tests make sure every kind of change that can matter changes the key (a
// stale table would route yesterday's network), that demand alone does not (or nothing is gained), and that routing
// with the kept tables is exactly routing without them.
const test = require('node:test');
const assert = require('node:assert/strict');
const fs = require('node:fs');
const path = require('node:path');
const { load } = require('./harness');
const { lit } = require('../scripts/lib/js-literal');
const SAVE = fs.readFileSync(path.join(__dirname, 'fixtures', 'big-network.json'), 'utf8');
function open() {
const h = load({ seed: 777 });
h.ev(`S=migrate(JSON.parse(${lit(SAVE)}));UI.started=true;UI.pitched=true;UI.speed=0;closeModal();S.nextFail=S.day+999;S.nextEvent=S.day+999;compute();compute();`);
return h;
}
// Applies a change, routes once with the kept tables and once without (from the same yesterday), and says which keys moved.
function step(ev, change) {
ev(change);
return JSON.parse(ev(`(()=>{const gk=RC.gk,xk=RC.xk,prior=R;compute();const a=JSON.stringify(R)+JSON.stringify(R.fl);
const g=RC.gk!==gk,x=RC.xk!==xk;R=prior;RC.on=false;try{compute();}finally{RC.on=true;}const b=JSON.stringify(R)+JSON.stringify(R.fl);
return JSON.stringify({g,x,same:a===b,len:a.length});})()`));
}
test('a change to links, POPs, ports, peering, events or RouteScript rebuilds what routing keeps; demand alone does not', () => {
const { ev, errors } = open();
assert.ok(ev('RC.gk!==null&&RC.xk!==null'), 'routing keeps its tables after a compute');
// [what changes, the graph key moves, the exits key moves]
const changes = [
// Demand and capacity only: nothing structural, the kept tables are used.
['for(const c in S.pops)if(S.pops[c].bb)S.pops[c].bb.d*=1.07', false, false],
['S.biz.forEach(b=>b.bw*=1.1)', false, false],
["S.links.find(l=>l.kind==='wave').tier=1", false, false],
['S.transit[0].tier=Math.max(0,S.transit[0].tier-1)', false, false],
['S.day++', false, false],
// The graph: a cut, a link gone, a link back, a metric, a POP down and up again, RouteScript's avoid.
['S.links[3].cut=S.day+3', true, true],
['S.links[3].cut=0', true, true],
['window.__l=S.links.splice(7,1)[0]', true, true],
['S.links.push(__l)', true, true],
["S.pairMet=S.pairMet||{};{const l=S.links[10];S.pairMet[l.a<l.b?l.a+'|'+l.b:l.b+'|'+l.a]='avoid';}", true, true],
['S.pops.sea.down=S.day+3', true, true],
['S.pops.sea.down=0', true, true],
// The exits: transit ports, PNIs, caches, exchanges, sessions.
["S.transit[2].pref='low'", false, true],
["S.transit[2].pref='high'", false, true],
['S.transit[5].carry=true', false, true],
['S.transit[4].down=S.day+3', false, true],
['S.transit.splice(1,1)', false, true],
["S.pni[0].pref='high'", false, true],
['S.pni.splice(10,25)', false, true],
['S.caches.splice(0,30)', false, true],
["S.ixPref={};S.ixPref[Object.keys(S.ixp)[1]]='low'", false, true],
['S.ev.ixdown={};S.ev.ixdown[Object.keys(S.ixp)[2]]=S.day+3', false, true],
['delete S.rs[Object.keys(S.rs)[0]]', false, true],
['delete S.ixp[Object.keys(S.ixp)[3]]', false, true],
// Events that change who reaches whom, and RouteScript.
["S.ev.rpki={nets:['ggl','nfx'],until:S.day+3}", false, true],
['S.ev.depeer=S.day+3', false, true],
["S.ev.leak={net:'fbk',until:S.day+3}", false, true],
["S.te={on:true,day:0,script:'prefer transit '+NET[S.transit[0].net].name+'\\nspill at 80%'};S.core={lv:2,run:2,legacy:true}", false, true],
["S.te.script+='\\nprefer pni for goggle'", false, true],
// avoid link: the edge's weight, so the graph key moves too.
["{const l=S.links.find(x=>!linkDown(x));S.te.script+='\\navoid link '+CITY[l.a].name.toLowerCase()+'-'+CITY[l.b].name.toLowerCase();}", true, true],
];
for (const [change, g, x] of changes) {
const r = step(ev, change);
assert.ok(r.same, `${change}: routing with the kept tables is routing without them`);
if (g !== null) assert.equal(r.g, g, `${change}: the graph key ${g ? 'moves' : 'stays'}`);
assert.equal(r.x, x, `${change}: the exits key ${x ? 'moves' : 'stays'}`);
assert.ok(r.len > 1e5, 'a big network was routed');
}
assert.deepEqual(errors, []);
});
test('days in a row reuse the kept tables and route like a fresh start every day', () => {
const { ev, errors } = open();
for (let d = 0; d < 4; d++) {
ev('dayTick()');
const r = step(ev, '');
assert.ok(r.same, `day ${d}: the same routing with and without the kept tables`);
assert.ok(!r.g && !r.x, `day ${d}: a day of demand only keeps the tables`);
}
assert.deepEqual(errors, []);
});
test('with Auto-TE, kept orders and the no-detour marks route like a fresh start every day', () => {
// The routing core (29-route-core.js) keeps each list's order for each city with the tables, and Auto-TE marks the
// pairs with no detour: both have to give exactly what scanning and searching afresh give. The network is made busy
// (half its link capacity) so that flows spill, detours are searched and many fail.
const { ev, errors } = open();
ev("S.core.run=2;S.te={on:true,day:S.day,script:'spill at 85%'};for(const b of S.biz)if(BIZ_T[b.type].l2&&b.city2)b.route='scenic';for(const l of S.links)if(l.kind==='wave')l.cap=(l.cap||0)/2;compute();compute();");
assert.equal(ev('!!(S.te.on&&coreTE())'), true);
let tried = 0;
for (let d = 0; d < 4; d++) {
ev('dayTick()');
const r = step(ev, '');
assert.ok(r.same, `day ${d}: the same routing with and without the kept tables`);
assert.ok(!r.g && !r.x, `day ${d}: a day of demand only keeps the tables`);
tried = Math.max(tried, ev('R.teMoved'));
}
assert.ok(tried > 0, 'Auto-TE moved traffic onto detours');
assert.deepEqual(errors, []);
});
// When the exits change but the graph does not (a network leaves an exchange because its PNI came up), the lists that
// did not change keep the orders routing worked out for them (the same arrays, used the same day), the ones that did
// start again, and routing is still exactly routing without the kept tables, day after day.
test('lists an exit change leaves alone keep their orders; routing stays the same as without the kept tables', () => {
const { ev, errors } = open();
// Two days on the kept build: the lists get their orders.
ev('compute();compute();');
ev('window.__ords=new Set(RC.x.lists.flatMap(d=>d.cs?d.ord.filter(Boolean):[d.ord]).filter(o=>Object.keys(o).length));');
assert.ok(ev('__ords.size') > 5, `orders worked out: ${ev('__ords.size')}`);
// One network leaves one exchange: the exits key moves, the graph does not.
const r = step(ev, `(()=>{const ix=Object.keys(S.ixp).find(x=>ixSessions(x).size>3),n=[...ixSessions(ix)][0];window.__left=n+'@'+ix;
S.peers[n+'@'+ix]=false;delete S.peers[n+'@'+ix];S.rs[ix]=false;S.pni.push({id:'pk1',net:n,city:ixCity(ix),tier:1,n:1});})()`);
assert.equal(r.g, false, 'same graph');
assert.equal(r.x, true, 'the exits changed');
assert.equal(r.same, true, 'the same routing as without the kept tables');
const kept = ev('RC.x.lists.flatMap(d=>d.cs?d.ord.filter(Boolean):[d.ord]).filter(o=>__ords.has(o)).length');
const all = ev('RC.x.lists.length');
assert.ok(kept > 0 && kept < ev('__ords.size') + 1, `lists that kept their orders: ${kept} of ${all}`);
// And a few more days, with the next change between them.
for (let d = 0; d < 3; d++) assert.equal(step(ev, 'for(const c in S.pops)if(S.pops[c].bb)S.pops[c].bb.d*=1.03').same, true, `day ${d + 1} after`);
assert.deepEqual(errors, []);
});
test('an exit that turns from an exchange into a PNI at the same place in the list does not keep its old order', () => {
const { ev, errors } = open();
// The last exchange with a few networks on it, its city A, and a network m there that also gets a PNI at A.
ev(`(()=>{const ixs=Object.keys(S.ixp).filter(c=>S.pops[ixCity(c)]);let p=null;
for(let k=ixs.length-1;k>=0&&!p;k--){const c=ixs[k],ss=[...ixSessions(c)];if(ss.length>2)p={c,A:ixCity(c),m:ss[0]};}
window.__P=p;for(const c of Object.keys(S.ixp).slice(Object.keys(S.ixp).indexOf(p.c)+1))delete S.ixp[c];
S.pni.push({id:'pz0',net:p.m,city:p.A,tier:1,n:1,pref:'normal'});})();compute();compute();compute();`);
assert.ok(ev('!!__P'), 'an exchange to drop');
// The exchange goes and a PNI with m at A comes first: an exit of the same city and preference, but now a PNI.
const r = step(ev, `delete S.ixp[__P.c];S.pni.unshift({id:'pz1',net:__P.m,city:__P.A,tier:1,n:1,pref:'normal'})`);
assert.equal(r.g, false, 'same graph');
assert.equal(r.x, true, 'the exits changed');
assert.equal(r.same, true, 'the same routing as without the kept tables');
assert.deepEqual(errors, []);
});