Fix CodeQL code-scanning alerts
- Values pasted into eval'd or inline-script code go through lit() (scripts/lib/js-literal.js), which escapes <, >, /, U+2028 and U+2029 after JSON.stringify - build test and i18n-check read script tags with a DOM parser or a plain search, not HTML regexes - mcp.js parses the Authorization header without a backtracking regex
This commit is contained in:
parent
e7729d0a1e
commit
dd6e4f4f8a
89 changed files with 316 additions and 213 deletions
|
|
@ -4,6 +4,7 @@ const assert = require('node:assert/strict');
|
|||
const path = require('node:path');
|
||||
const { execFileSync } = require('node:child_process');
|
||||
const { load } = require('./harness');
|
||||
const { lit } = require('../scripts/lib/js-literal');
|
||||
|
||||
const RN = path.join(__dirname, '..', 'scripts', 'release-notes.js');
|
||||
const run = (...a) => JSON.parse(execFileSync(process.execPath, [RN, ...a], { encoding: 'utf8' }));
|
||||
|
|
@ -22,7 +23,7 @@ test('the release notes script reads a story and the bullets apart', () => {
|
|||
test('"What\'s new" tells the story in full, with every change one tap away', () => {
|
||||
const { ev, errors } = load();
|
||||
const story = run('2.0.0', '--story');
|
||||
ev(`RELEASE_STORY.splice(0,0,...${JSON.stringify(story)});RELEASE_NOTES.splice(0,0,...${JSON.stringify(run('2.0.0'))})`);
|
||||
ev(`RELEASE_STORY.splice(0,0,...${lit(story)});RELEASE_NOTES.splice(0,0,...${lit(run('2.0.0'))})`);
|
||||
ev('openModal(notesHtml(RELEASE_NOTES,APP_VERSION))');
|
||||
const html = ev("document.getElementById('modalCard').innerHTML"), text = ev("document.getElementById('modalCard').textContent");
|
||||
assert.equal(ev("document.querySelectorAll('#modalCard .story p').length"), story.length, 'every paragraph, no "and N more"');
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue