Diagnostic info: say how often the map was drawn, and drop a key no release had
The loop runs at the screen's rate even when a still map is not drawn again, so the readout's "fps" said 60 or 240 on
a map that was not being drawn at all, which a bug report would take for the map's speed. It now also says how often
the map was drawn ("map drawn N/s"). The sot-fps setting it carried over only ever existed on this branch, never in a
release, so it is no longer read or removed; ?fps and ?nofps still open and close the readout.
This commit is contained in:
parent
b7a9ec3e3c
commit
c652bce7d2
2 changed files with 12 additions and 10 deletions
|
|
@ -10,10 +10,11 @@ function diagFrame(now){const D=DIAG;if(D.last)D.fr.push(now-D.last);D.last=now;
|
|||
// What draws the map, and why it is the 2D canvas when it is.
|
||||
function diagMap(){if(!S)return 'map: none (title screen)';if(pzOn())return 'map: 2D (puzzle)';if(!GLX.want)return 'map: 2D (Always 2D)';
|
||||
if(GLX.dead)return 'map: 2D ('+(GLX.why||'no WebGL2')+')';if(GLX.lost)return 'map: 2D (graphics context lost, waiting for it back)';return GLX.gl&&GLX.shown?'map: WebGL2 · '+(GLX.gpu||'unknown GPU'):'map: WebGL2 (starting)';}
|
||||
// Frames since the last readout: per second, the 95th percentile and the slowest, and draw()'s mean.
|
||||
// Frames since the last readout: per second, the 95th percentile and the slowest, and draw()'s mean. The loop runs at
|
||||
// the screen's rate even when a still map is not drawn again (mapStill()), so how often it was drawn is shown too.
|
||||
function diagPerf(){const f=DIAG.fr.splice(0),d=DIAG.dr.splice(0),s=f.slice().sort((a,b)=>a-b),sum=f.reduce((a,x)=>a+x,0),
|
||||
q=x=>s.length?s[Math.min(s.length-1,Math.floor(s.length*x))].toFixed(0):'-',gl=GLX.shown&&!GLX.dead;
|
||||
return `${sum?(f.length*1000/sum).toFixed(0):'-'} fps · p95 ${q(.95)} ms · max ${q(1)} ms\ndraw ${d.length?(d.reduce((a,x)=>a+x,0)/d.length).toFixed(1):'-'} ms · x${UI.speed||0} · zoom ${cam.z.toFixed(2)}`+
|
||||
return `${sum?(f.length*1000/sum).toFixed(0):'-'} fps · map drawn ${sum?(d.length*1000/sum).toFixed(0):'-'}/s · p95 ${q(.95)} ms · max ${q(1)} ms\ndraw ${d.length?(d.reduce((a,x)=>a+x,0)/d.length).toFixed(1):'-'} ms · x${UI.speed||0} · zoom ${cam.z.toFixed(2)}`+
|
||||
(gl?` · ${GLX.nSeg} segments · ${GLX.nPk} packets`:'');}
|
||||
function diagShow(){const D=DIAG;let el=D.el;
|
||||
if(!el){el=D.el=document.createElement('pre');el.id='diag';el.style.cssText='position:fixed;left:8px;bottom:calc(var(--tabbar,0px) + 8px);z-index:99;margin:0;padding:6px 8px;max-width:calc(100vw - 32px);background:rgba(30,38,64,.85);color:#7CFFB2;font:11px/1.35 ui-monospace,monospace;border-radius:8px;pointer-events:none;white-space:pre-wrap;overflow-wrap:anywhere';
|
||||
|
|
@ -30,7 +31,7 @@ function diagShow(){const D=DIAG;let el=D.el;
|
|||
// Shows or hides the readout, and remembers it on this device.
|
||||
function diagOn(on){const D=DIAG;clearInterval(D.t);D.t=null;if(D.el){D.el.remove();D.el=null;}D.on=!!on;D.fr.length=D.dr.length=0;D.last=0;D.dms=-1;
|
||||
if(on){D.t=setInterval(diagShow,500);diagShow();}
|
||||
try{on?localStorage.setItem('sot-vp','1'):localStorage.removeItem('sot-vp');localStorage.removeItem('sot-fps');}catch(e){}}
|
||||
{const q=location.search;let on=false;try{on=localStorage.getItem('sot-vp')==='1'||localStorage.getItem('sot-fps')==='1';}catch(e){}
|
||||
try{on?localStorage.setItem('sot-vp','1'):localStorage.removeItem('sot-vp');}catch(e){}}
|
||||
{const q=location.search;let on=false;try{on=localStorage.getItem('sot-vp')==='1';}catch(e){}
|
||||
if(/[?&](vp|fps)\b/.test(q))on=true;else if(/[?&]no(vp|fps)\b/.test(q))on=false;diagOn(on);}
|
||||
{let taps=[];document.getElementById('hDate').closest('.chip,div').addEventListener('click',()=>{const t=performance.now();taps=taps.filter(x=>t-x<1500).concat(t);if(taps.length>=5){taps=[];diagOn(!DIAG.on);}});}
|
||||
|
|
|
|||
|
|
@ -63,21 +63,22 @@ test('it measures frames per second, the slowest frames and draw()', () => {
|
|||
const { ev, errors } = h;
|
||||
try {
|
||||
ev('diagOn(true)');
|
||||
// 60 frames, so 59 intervals: 58 of 16 ms and a last one of 50 ms (978 ms in all), each map drawn in 2 ms.
|
||||
ev('let t=1000;for(let i=0;i<60;i++){t+=i===59?50:16;DIAG.dms=2;diagFrame(t);}diagShow();');
|
||||
// 60 frames, so 59 intervals: 58 of 16 ms and a last one of 50 ms (978 ms in all); the map drawn on every other
|
||||
// one (a still map is not drawn again), in 2 ms: 30 in 978 ms, 31 a second.
|
||||
ev('let t=1000;for(let i=0;i<60;i++){t+=i===59?50:16;if(i%2)DIAG.dms=2;diagFrame(t);}diagShow();');
|
||||
const t = text(ev);
|
||||
assert.match(t, /\b60 fps · p95 16 ms · max 50 ms/);
|
||||
assert.match(t, /\b60 fps · map drawn 31\/s · p95 16 ms · max 50 ms/);
|
||||
assert.match(t, /draw 2\.0 ms · x0 · zoom /);
|
||||
assert.deepEqual(errors, []);
|
||||
} finally { h.done(); }
|
||||
});
|
||||
|
||||
test('?fps and ?vp open it, ?nofps closes it, and the old frame meter setting carries over', () => {
|
||||
for (const [url, storage, want] of [['?fps', {}, true], ['?vp', {}, true], ['?nofps', { 'sot-vp': '1' }, false], ['', { 'sot-fps': '1' }, true], ['', {}, false]]) {
|
||||
test('?fps and ?vp open it, ?nofps closes it, and it stays open on this device', () => {
|
||||
for (const [url, storage, want] of [['?fps', {}, true], ['?vp', {}, true], ['?nofps', { 'sot-vp': '1' }, false], ['', { 'sot-vp': '1' }, true], ['', {}, false]]) {
|
||||
const h = load({ seed: 777, url: 'https://tests.invalid/' + url, storage });
|
||||
try {
|
||||
assert.equal(h.ev('!!document.getElementById("diag")'), want, `${url || 'no flag'} ${JSON.stringify(storage)}`);
|
||||
assert.equal(h.ev('localStorage.getItem("sot-fps")'), null, 'the old key is gone');
|
||||
assert.equal(h.ev('localStorage.getItem("sot-vp")'), want ? '1' : null, 'remembered as one setting');
|
||||
} finally { h.dom.window.close(); }
|
||||
}
|
||||
});
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue