Clear the open code scanning alerts
- auto-release.yml: the by-hand test run passes github.sha (what it got anyway) instead of an output that also reads workflow_run.head_sha, so CI never checks out a ref a workflow_run handed over in a job that uses caches (cache poisoning, 7 alerts in ci.yml). - tests/harness.js: the script splitter also matches end tags like </SCRIPT > (bad HTML filtering regexp). - Tests paste the fixture saves into the page with lit(), which escapes what could end a script or a string, instead of plain JSON.stringify (improper code sanitization).
This commit is contained in:
parent
f00bc733d0
commit
4630ba99af
9 changed files with 18 additions and 11 deletions
5
.github/workflows/auto-release.yml
vendored
5
.github/workflows/auto-release.yml
vendored
|
|
@ -70,13 +70,14 @@ jobs:
|
|||
case "$ver" in *-*) echo "pre=true" >> "$GITHUB_OUTPUT";; *) echo "pre=false" >> "$GITHUB_OUTPUT";; esac
|
||||
echo "skip=false" >> "$GITHUB_OUTPUT"
|
||||
|
||||
# Only when started by hand: after a push, CI has already tested this commit.
|
||||
# Only when started by hand: after a push, CI has already tested this commit. By hand the commit is main as it is
|
||||
# (github.sha, what check.outputs.sha is then), named directly so CI never checks out a ref a workflow_run handed over.
|
||||
tests:
|
||||
needs: check
|
||||
if: needs.check.outputs.skip == 'false' && github.event_name == 'workflow_dispatch'
|
||||
uses: ./.github/workflows/ci.yml
|
||||
with:
|
||||
ref: ${{ needs.check.outputs.sha }}
|
||||
ref: ${{ github.sha }}
|
||||
|
||||
release:
|
||||
needs: [check, tests]
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue