Ship short ids instead of labels; checker, tests and docs for labels
The build swaps every label for a short id in the shipped page, the inlined English and the translation files (scripts/lib/compile-labels.js). Labels passed to N_() stay whole because saves keep them. Against 1.33: page +4% gzipped (321 -> 335 KB), translations -40% (it.js 143 -> 85 KB); routing, day, panels, dashboard, map and boot time unchanged. - i18n-check rejects labels the build cannot see (outside tr/trn/N_) - tests/pages.test.js plays the shipped page in English, Italian and French - docs/adr/0003, add-strings skill, ARCHITECTURE, README, CONTRIBUTING, CLAUDE.md describe labels
This commit is contained in:
parent
9043af5ab0
commit
0057e74472
14 changed files with 253 additions and 63 deletions
|
|
@ -30,7 +30,8 @@ function load(opts = {}) {
|
|||
for (const [k, v] of Object.entries(opts.storage || {})) window.localStorage.setItem(k, v);
|
||||
if (opts.navigatorLanguage) Object.defineProperty(window.navigator, 'language', { value: opts.navigatorLanguage });
|
||||
// A non-English game: jsdom does not fetch the dictionary script, so register it up front.
|
||||
if (opts.lang) { window.localStorage.setItem('sot-lang', opts.lang); window.eval(fs.readFileSync(path.join(__dirname, '..', 'site', 'i18n', opts.lang + '.js'), 'utf8')); }
|
||||
// (opts.dir: the folder the dictionary comes from, e.g. a build's _site/i18n.)
|
||||
if (opts.lang) { window.localStorage.setItem('sot-lang', opts.lang); window.eval(fs.readFileSync(path.join(opts.dir || path.join(__dirname, '..', 'site', 'i18n'), opts.lang + '.js'), 'utf8')); }
|
||||
window.Path2D = class { moveTo() {} lineTo() {} quadraticCurveTo() {} bezierCurveTo() {} arc() {} rect() {} closePath() {} };
|
||||
// A recording 2D context, so draw code really runs under test (jsdom has no canvas).
|
||||
const fake = () => { const calls = { n: 0 };
|
||||
|
|
|
|||
|
|
@ -152,3 +152,11 @@ for (const lang of ['en', 'it', 'pt', 'fr']) {
|
|||
assert.deepEqual(errors, []);
|
||||
});
|
||||
}
|
||||
|
||||
test('the translation check catches labels the build could not see, and English-keyed calls', () => {
|
||||
const { sourceLabels } = require('../scripts/i18n-check');
|
||||
const { problems, labels } = sourceLabels("<html><body><script>const x='pnis.foo_bar';tr('pnis.ok_label');N_('pnis.kept');trn('{n} POP','{n} POPs',n)</script></body></html>");
|
||||
assert.ok(labels.has('pnis.ok_label') && labels.has('pnis.kept'));
|
||||
assert.ok(problems.some((p) => p.includes('pnis.foo_bar') && p.includes('N_()')), 'a bare label');
|
||||
assert.ok(problems.some((p) => p.includes('not a label')), 'English text where a label belongs');
|
||||
});
|
||||
|
|
|
|||
|
|
@ -70,3 +70,19 @@ test('pages: only the release workflow deploys, and only with the GitHub Pages a
|
|||
assert.match(rel, /actions\/deploy-pages@/);
|
||||
assert.match(rel, /path: \.\/_site/);
|
||||
});
|
||||
|
||||
test('pages: the shipped page and dictionaries, with labels shrunk to ids, still say the right things', () => {
|
||||
const { load } = require('./harness');
|
||||
const file = path.join(OUT, 'index.html'), dir = path.join(OUT, 'i18n');
|
||||
assert.doesNotMatch(read('index.html'), /tr\('pnis\.delivery/, 'labels are shrunk in the shipped page');
|
||||
for (const [lang, word] of [['en', 'Customers'], ['it', 'Clienti'], ['fr', null]]) {
|
||||
const { ev, errors } = load(lang === 'en' ? { file } : { file, lang, dir });
|
||||
ev("ACT.start({});S.cash=1e8;ACT.launchBB({city:'fra'});for(let i=0;i<40;i++)dayTick();ACT.leftTab({t:'noc'});renderAll()");
|
||||
const text = ev("['hud','leftBody','panelBody','modalCard','toasts'].map(i=>document.getElementById(i)?.textContent||'').join(' ')");
|
||||
if (word) assert.ok(text.includes(word), `${lang}: ${word}`);
|
||||
assert.doesNotMatch(text, /\b[a-z_]+\.[a-z0-9_]{6,}\b/, `${lang}: no raw labels`);
|
||||
assert.equal(ev("tr(FLOOD_WHO[0])"), ev("tr('failures.a_botnet_of_40_000_smart')"), `${lang}: labels kept for saves still translate`);
|
||||
assert.notEqual(ev("tr(FLOOD_WHO[0])"), 'failures.a_botnet_of_40_000_smart');
|
||||
assert.deepEqual(errors, []);
|
||||
}
|
||||
});
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue