Ship short ids instead of labels; checker, tests and docs for labels
The build swaps every label for a short id in the shipped page, the inlined English and the translation files (scripts/lib/compile-labels.js). Labels passed to N_() stay whole because saves keep them. Against 1.33: page +4% gzipped (321 -> 335 KB), translations -40% (it.js 143 -> 85 KB); routing, day, panels, dashboard, map and boot time unchanged. - i18n-check rejects labels the build cannot see (outside tr/trn/N_) - tests/pages.test.js plays the shipped page in English, Italian and French - docs/adr/0003, add-strings skill, ARCHITECTURE, README, CONTRIBUTING, CLAUDE.md describe labels
This commit is contained in:
parent
9043af5ab0
commit
0057e74472
14 changed files with 253 additions and 63 deletions
|
|
@ -54,9 +54,10 @@ npm run perf -- --base-ref origin/main --browser # the same, also in real Chro
|
|||
a real pun, or keep the plain word.
|
||||
- **Easter eggs stay secret.** Never mention hidden jokes or easter eggs (for example
|
||||
whatever `elephant()` does) in commit messages, release notes or the CHANGELOG.
|
||||
- **Every player-facing string is translated.** Wrap it in `tr()`, `trn()` or `N_()`
|
||||
and add every translation (`site/i18n/*.js`) in the same change with `scripts/i18n-add.js`
|
||||
(see `add-strings`).
|
||||
- **Every player-facing string is translated, by label.** Code uses `tr('area.label')`,
|
||||
`trn('area.label', n)` or `N_('area.label')` (anything stored in a save: `N_()`), never English text.
|
||||
Add the English (`src/i18n/en.js`) and every translation (`site/i18n/*.js`) in the same change with
|
||||
`scripts/i18n-add.js` (see `add-strings`).
|
||||
- **Phones first.** About 70% of players are on phones. Every new panel, button and
|
||||
modal must work at 360 px wide, in portrait and landscape, using the phone tab bar
|
||||
and bottom sheets. Check `isPhone()` layouts, not just desktop.
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue