Upstream/test/report-share-cleanup.test.js
jvanvik 931f59e11e Phase 3: trade/end-game client, bot simulator, first balance pass
Built:
- Client: trade screen, world/end-game screen (landing sites, shipping, node build, final ranking), report sharing + alliance reports tab, alert describers for all notification types, error-code strings (en+nb) for every server CODE.
- tools/bot.js (+ tools/bot/): 50 headless bots against the real server in-process with a fake clock; resource/unit conservation ledger, exit 1 on broken invariants. docs/BALANCE.md has method and every run behind a number.
- Balance changes (evidence in docs/BALANCE.md): secondQueueCoreLevel 10 -> 3, TRANSPORT.capacityPerLink 500 -> 1000 (end game was shipping-limited in bot runs).
- Server fixes: POST /reports/:id/share 500 without a pending reportCleanup; bounced link shipments were silent about cargo overflow.

Tested: npm test 207/207 (new: bot determinism + invariants, client alerts/world/i18n over CODES, two regression tests that failed before their fix); openapi check up to date. Real-browser scratch runs (not in repo): WebSocket push shows an incoming-attack banner ~214 ms after launch, polling fallback ~52 s, 15 scripted flows, 71 screenshots.

NOT tested: Playwright suite (e2e/ still empty), real devices/Safari, nginx proxy websockets, throttled networks, HTTP-level bot load. NOT claimed: balance. Bots are not humans; open balance items (loot waste, escrow refund clipping, no garrisons at landing sites, end game not scaling with world speed) are listed in docs/BALANCE.md.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q2MJaQ5LXAHzGnTDgceT14
2026-10-11 20:24:41 +02:00

21 lines
1.5 KiB
JavaScript

'use strict';
/* Regression: sharing a report when no reportCleanup event is pending used to throw (ensureCleanup needs ctx.enqueue, which a plain
* command ctx lacks) and surface as a 500. Found in a browser run with hand-made reports. */
const test = require('node:test');
const assert = require('node:assert');
const T = require('./military-helpers');
const A = require('../server/alliances');
test('reportShare works when no cleanup event is pending and then schedules one', () => {
const h = T.setup();
const a = T.addOperator(h, 'alice');
const al = Number(h.db.run('INSERT INTO alliances (world_id, name, tag, size_cap, created_by, created_at) VALUES (?, ?, ?, 10, ?, ?)', h.worldId, 'Alpha', 'ALP', a.opId, h.clock.now()).lastInsertRowid);
A.addMember(h.db, al, a.opId, 'leader', h.clock.now());
const rid = Number(h.db.run('INSERT INTO reports (world_id, type, created_at, expires_at, summary, data) VALUES (?, ?, ?, ?, ?, ?)', h.worldId, 'scan', h.clock.now(), h.clock.now() + 1000, '{}', '{}').lastInsertRowid);
h.db.run('INSERT INTO report_recipients (report_id, user_id, role) VALUES (?, ?, ?)', rid, a.userId, 'attacker');
assert.equal(h.db.get("SELECT COUNT(*) n FROM events WHERE type = 'reportCleanup' AND status = 'pending'").n, 0);
const r = h.run('reportShare', { userId: a.userId, reportId: rid });
assert.equal(r.changed, true);
assert.equal(h.db.get("SELECT COUNT(*) n FROM events WHERE type = 'reportCleanup' AND status = 'pending'").n, 1);
assert.equal(h.run('reportShare', { userId: a.userId, reportId: rid }).changed, false);
});