Upstream/server/commands/withdrawGarrison.js
jvanvik 3c23c51902 Phase 4: close loot/refund leaks, landing-site garrisons, speed-scaled shipping, update/offsite tooling, broad e2e
Built:
- Economy: raid loot capped to the room the raiders have at home (rest stays with the victim, "lootLeft" in the report); trade escrow reserves its room so refunds always fit; trade accept refuses with no_room_for_goods when the goods would not fit. Loot destroyed per 30-day run 31-61k -> ~1k, refunds clipped ~27k -> 0 (docs/BALANCE.md, 3 seeds).
- End game: members of the holding alliance garrison landing sites (migration 005_site_garrison.sql), garrison counts in site defence, 72 h capture shield, withdraw route, POP view lists garrisoned units. Shipping capacity scales with world speed (3x world: winner 76-98 -> ~30-36 days after sites open). Bot runs show real contests (84-194 attacks on held sites at 1x).
- Ops: deploy/update.sh (backup, stop, ff-merge, npm ci --ignore-scripts, health check, rollback), deploy/upstream-offsite (rsync only), admin end-world snapshots results, EPIPE fix, docs/workflows/ filled in.
- e2e 62 -> 163 checks: units, raids/reports, alliance+messages, trade, end game, nb, PWA, reconnect, slow polling fallback (opt-in). Two app bugs found: message push ignored, "New" button stayed English.

Tested: npm test 274/274, openapi check, npm run e2e 163/163 (137 s), bot runs 50x30d seeds 1-3 and 140-day/60-day speed-3 end-game runs INVARIANTS OK, adversarial review pass (findings fixed or documented).
NOT tested: update.sh on a real box (systemd, real npm, runuser; stubs only, shellcheck not installed), garrison card/loot text on a phone, Node 22.13, humans. Known leaks left open and documented (BALANCE S6): loot/shipments can still overflow when stock arrives in flight, bounced backbone shipments lose overflow (reported to the sender). Garrison numbers (heldDefenceMult 2, shield 72 h) are first guesses from 2 seeds. Not claimed: balanced.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q2MJaQ5LXAHzGnTDgceT14
2026-10-12 00:58:12 +02:00

30 lines
1.9 KiB
JavaScript

'use strict';
/*
* POST /backbone/:id/withdraw {fromTownId, units?}: units of one of YOUR POPs that stand in a landing site go home. Only their owner can
* call them back (the holding alliance has no way to send somebody else's units away; leaving the alliance does it automatically).
* `units` defaults to the whole group. They stop defending the site and stop drawing the owner's power at once, and drive home as a
* return movement (so they are in no battle on the way). Works whoever holds the site now, also after it changed hands.
*/
const { GameError } = require('../errors');
const { ownedTown } = require('./build');
const ctxOf = require('../military/ctx');
const U = require('../military/units');
const G = require('../military/garrison');
const E = require('../endgame');
module.exports = function withdrawGarrison(ctx0, { userId, siteId, fromTownId, units }) {
const ctx = ctxOf(ctx0);
const { db } = ctx;
const site = E.siteRow(db, siteId);
if (!site) throw new GameError('not_found', { what: 'landing site' });
const owner = ownedTown(db, userId, fromTownId);
if (owner.worldId !== site.world_id) throw new GameError('not_found', { what: 'town' });
const have = G.ownedAt(db, site.id, owner.id);
let take = units && Object.keys(units).length ? U.cleanUnits(units) : have;
take = Object.fromEntries(Object.entries(take).filter(([, n]) => n > 0));
if (U.isEmpty(take)) throw new GameError('not_enough_units', { reason: 'nothing stationed' });
for (const k of Object.keys(take)) if ((have[k] || 0) < take[k]) throw new GameError('not_enough_units', { unit: k, have: have[k] || 0, want: take[k] });
const mv = G.sendHome(ctx, site, owner.id, take, { withdrawn: true });
if (!mv) throw new GameError('conflict', { what: 'no POP to return to' });
return { movementId: mv.id, siteId: site.id, fromTownId: owner.id, units: take, arriveAt: mv.arriveAt };
};