Upstream/server/commands/renameTown.js
jvanvik d84b0c9d12 Fix review findings: proto smuggling, trade-leg recall, escrow cap, static headers, rate limits, rankings DoS
Fixed: validator rejects __proto__/constructor keys at any depth (transport capacity bypass); trade and site shipments
cannot be recalled; trade escrow refund capped by Rack hall; CSP/nosniff on static files and connect-src 'self';
IPv6 /64 limiter keys + LRU eviction + per-username login bucket + scrypt concurrency cap; 5 s footprint cache for
rankings; rename uses text.cleanText; 429s no longer pinned in the idempotency store; 30-day notification prune;
units_offline notification on first offline. Accepted items listed in docs/DECISIONS.md R1.
Tested: npm test 182/182 incl. test/review-fixes.test.js (regression tests). Not re-reviewed after the fixes.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q2MJaQ5LXAHzGnTDgceT14
2026-10-11 19:06:51 +02:00

20 lines
804 B
JavaScript

'use strict';
const { GameError } = require('../errors');
const { ownedTown } = require('./build');
const { cleanText } = require('../text');
// Display-name hygiene (same rules as every other player-typed text): no control/bidi/invisible characters,
// collapsed whitespace, at most 24 characters.
function cleanName(v) {
return Array.from(cleanText(v)).slice(0, 24).join('').trim();
}
module.exports = function renameTown(ctx, { userId, townId, name }) {
const town = ownedTown(ctx.db, userId, townId);
const clean = cleanName(name);
if (clean.length < 2) throw new GameError('validation_failed', { errors: [{ path: 'name', message: 'too short' }] });
ctx.db.run('UPDATE towns SET name = ? WHERE id = ?', clean, town.id);
return { name: clean };
};
module.exports.cleanName = cleanName;