Phase 2: client military/social screens, WebSocket push, trade + endgame, review findings pending

Built: units/movements/reports/send/expansion screens, alliance/messages/rankings screens, ws client + server /ws push
(docs/PROTOCOL.md), Internet exchange trade, backbone endgame + world end, shared reports, buildDone relative levels.
Tested: npm test 175/175. Two adversarial reviews found issues (trade-leg recall exploit, __proto__ via validate.js,
rankings DoS, static headers, ...): fixes follow in the next commit.
NOT done: bots/balance, e2e suite, real-device checks.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q2MJaQ5LXAHzGnTDgceT14
This commit is contained in:
jvanvik 2026-10-11 19:05:03 +02:00
parent 249818a7aa
commit b18645dca1
87 changed files with 10201 additions and 71 deletions

75
test/trade-api.test.js Normal file
View file

@ -0,0 +1,75 @@
'use strict';
/* Trade over HTTP: routes, validation, error codes, pagination, and the declared response schemas (contract: true). */
const test = require('node:test');
const assert = require('node:assert');
const { createTestServer } = require('./helpers');
const D = require('../public/js/data.js');
test('trade API: post, list, take, mine, detail, cancel, errors', async () => {
const t = await createTestServer({ contract: true });
try {
const a = await t.signup('alice'), b = await t.signup('bob'), c = await t.signup('cara');
for (const u of [a, b]) t.setBuilding(u.townId, 'internet_exchange', 3);
// cara has no exchange at all
const body = (o) => Object.assign({ townId: a.townId, giveRes: 'fiber', giveAmount: 400, wantRes: 'hardware', wantAmount: 300, maxDistance: 40 }, o || {});
const bad = await t.api('/trade/offers', { method: 'POST', body: body({ giveAmount: 500, wantAmount: 200 }) }, a.token);
assert.equal(bad.status, 409); assert.equal(bad.body.error.code, 'trade_ratio');
assert.equal((await t.api('/trade/offers', { method: 'POST', body: body({ wantRes: 'fiber' }) }, a.token)).status, 422);
assert.equal((await t.api('/trade/offers', { method: 'POST', body: body({ townId: b.townId }) }, a.token)).status, 404);
assert.equal((await t.api('/trade/offers', { method: 'POST', body: body() })).status, 401);
const made = await t.api('/trade/offers', { method: 'POST', body: body() }, a.token);
assert.equal(made.status, 201);
const id = made.body.offer.id;
assert.equal(made.body.offer.give.amount, 400);
assert.equal((await t.api('/trade/offers', { method: 'POST', body: body({ giveAmount: 100, wantAmount: 100, giveRes: 'capital' }) }, a.token)).status, 201);
const listB = await t.api('/trade/offers', {}, b.token);
assert.equal(listB.status, 200);
assert.equal(listB.body.items.length, 2);
assert.equal(listB.body.items[0].id > listB.body.items[1].id, true, 'newest first');
const p1 = await t.api('/trade/offers?limit=1', {}, b.token);
assert.equal(p1.body.items.length, 1);
const p2 = await t.api('/trade/offers?limit=1&after=' + p1.body.next, {}, b.token);
assert.equal(p2.body.items[0].id, id);
assert.equal(p2.body.next, null);
assert.equal((await t.api('/trade/offers?give=capital', {}, b.token)).body.items.length, 1, 'filter by offered resource');
assert.equal((await t.api('/trade/offers?want=capital', {}, b.token)).body.items.length, 0);
assert.equal((await t.api('/trade/offers', {}, a.token)).body.items.length, 0, 'not your own');
assert.equal((await t.api('/trade/offers', {}, c.token)).body.items.length, 0, 'no exchange: you see nothing');
assert.equal((await t.api('/trade/offers?give=gold', {}, b.token)).status, 422);
const one = await t.api('/trade/offers/' + id, {}, c.token);
assert.equal(one.body.offer.status, 'open', 'open offers are public inside the world');
const acc = await t.api('/trade/offers/' + id + '/accept', { method: 'POST', body: { townId: b.townId } }, b.token);
assert.equal(acc.status, 201);
assert.equal(acc.body.status, 'accepted');
assert.equal((await t.api('/trade/offers/' + id + '/accept', { method: 'POST', body: { townId: b.townId } }, b.token)).body.error.code, 'offer_closed');
assert.equal((await t.api('/trade/offers/' + id, {}, c.token)).status, 404, 'closed offers are for the two parties');
t.clock.advance(acc.body.arriveAt - t.clock.now());
t.srv.scheduler.runDue();
const mineA = await t.api('/trade/offers/mine', {}, a.token), mineB = await t.api('/trade/offers/mine?status=completed', {}, b.token);
assert.equal(mineA.body.items.length, 2);
assert.equal(mineB.body.items[0].status, 'completed');
assert.equal(mineB.body.items[0].role, 'acceptor');
const notes = await t.api('/notifications', {}, a.token);
assert.ok(notes.body.items.some((n) => n.type === 'trade_completed'));
const other = await t.api('/trade/offers', { method: 'GET' }, b.token);
const open = other.body.items[0];
assert.equal((await t.api('/trade/offers/' + open.id, { method: 'DELETE' }, b.token)).status, 404);
const del = await t.api('/trade/offers/' + open.id, { method: 'DELETE' }, a.token);
assert.equal(del.status, 200);
assert.deepEqual(del.body.returned, { resource: 'capital', amount: 100 });
// the Idempotency-Key makes a retried POST safe: one offer, not two
const k = { 'idempotency-key': 'offer-retry-0001' };
const r1 = await t.api('/trade/offers', { method: 'POST', body: body({ giveAmount: 50, wantAmount: 50 }), headers: k }, a.token);
const r2 = await t.api('/trade/offers', { method: 'POST', body: body({ giveAmount: 50, wantAmount: 50 }), headers: k }, a.token);
assert.equal(r1.body.offer.id, r2.body.offer.id);
assert.equal(t.srv.db.get("SELECT COUNT(*) AS n FROM trade_offers WHERE give_amount = 50").n, 1);
void D;
} finally { await t.close(); }
});