Phase 3: trade/end-game client, bot simulator, first balance pass

Built:
- Client: trade screen, world/end-game screen (landing sites, shipping, node build, final ranking), report sharing + alliance reports tab, alert describers for all notification types, error-code strings (en+nb) for every server CODE.
- tools/bot.js (+ tools/bot/): 50 headless bots against the real server in-process with a fake clock; resource/unit conservation ledger, exit 1 on broken invariants. docs/BALANCE.md has method and every run behind a number.
- Balance changes (evidence in docs/BALANCE.md): secondQueueCoreLevel 10 -> 3, TRANSPORT.capacityPerLink 500 -> 1000 (end game was shipping-limited in bot runs).
- Server fixes: POST /reports/:id/share 500 without a pending reportCleanup; bounced link shipments were silent about cargo overflow.

Tested: npm test 207/207 (new: bot determinism + invariants, client alerts/world/i18n over CODES, two regression tests that failed before their fix); openapi check up to date. Real-browser scratch runs (not in repo): WebSocket push shows an incoming-attack banner ~214 ms after launch, polling fallback ~52 s, 15 scripted flows, 71 screenshots.

NOT tested: Playwright suite (e2e/ still empty), real devices/Safari, nginx proxy websockets, throttled networks, HTTP-level bot load. NOT claimed: balance. Bots are not humans; open balance items (loot waste, escrow refund clipping, no garrisons at landing sites, end game not scaling with world speed) are listed in docs/BALANCE.md.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q2MJaQ5LXAHzGnTDgceT14
This commit is contained in:
jvanvik 2026-10-11 20:24:41 +02:00
parent d84b0c9d12
commit 931f59e11e
49 changed files with 4750 additions and 59 deletions

View file

@ -12,6 +12,7 @@ const D = require('../../public/js/data.js');
const { GameError } = require('../errors');
const A = require('../alliances');
const { ensureCleanup } = require('../military/reports');
const ctxOf = require('../military/ctx');
function context(db, userId, reportId) {
const rep = db.get(`SELECT r.id, r.world_id, r.expires_at FROM reports r JOIN report_recipients rr ON rr.report_id = r.id AND rr.user_id = ? WHERE r.id = ?`, userId, reportId);
@ -23,7 +24,8 @@ function context(db, userId, reportId) {
return { rep, op, member: m };
}
function reportShare(ctx, { userId, reportId }) {
function reportShare(ctx0, { userId, reportId }) {
const ctx = ctxOf(ctx0); // ensureCleanup enqueues: a plain command ctx has no enqueue (was a 500 when no cleanup event was pending)
const { db, now } = ctx;
const { rep, op, member } = context(db, userId, reportId);
if (!R.allianceCan(member.role, 'shareReport')) throw new GameError('forbidden', { need: 'shareReport', role: member.role });

View file

@ -24,5 +24,7 @@ module.exports = function ret(ctx, ev) {
U.addHome(db, town.id, mv.units);
const lost = addCargo(db, town, mv.cargo);
P.reschedule(ctx, town.id, ev.dueAt);
if (uid && !mv.extra.link) ctx.notify(uid, mv.worldId, 'movement_returned', { movementId: mv.id, townId: town.id, units: mv.units, cargo: mv.cargo, cargoLost: lost });
// Empty carriers coming home (extra.link) are silent; a bounced shipment that carries cargo is not: its overflow is reported.
const carrying = D.RESOURCES.some((r) => mv.cargo && mv.cargo[r] > 0);
if (uid && (!mv.extra.link || carrying)) ctx.notify(uid, mv.worldId, 'movement_returned', { movementId: mv.id, townId: town.id, units: mv.units, cargo: mv.cargo, cargoLost: lost });
};