Apply code-review fixes: identity/pagination, load races, TLS pin, leaks
Addresses a multi-agent code review (26 confirmed findings + a URLSession leak) across correctness, concurrency, security, and cleanup: - MongoDocument.id: deterministic fallback (was UUID() on every access) to stop SwiftUI List/ForEach identity churn; getAll pagination drives its cursor off the real _id via documentId, so a missing _id stops paging instead of looping on a fabricated cursor. - View models: per-load generation guard (+ captured-tab guard on ONU detail) so a cancelled or overlapping load can't commit stale results or land data on the wrong tab. - JSONValue.intValue: guard Int(d) against NaN/inf/out-of-range (crash). - ServerTrustEvaluator: hash the real SubjectPublicKeyInfo (prepend the algorithm-specific ASN.1 SPKI header) so a standard openssl-captured public-key pin actually matches; unknown key types fail closed. - AppEnvironment.configure: clear stale cookies + Keychain creds on host change. - FirmwareFile.isCompatible: empty metadata no longer passes as compatible-for-all. - APIClient: invalidate URLSession on deinit (per-configure/probe leak). - Dashboard best-effort sections keep last-good on transient failure; unified optical thresholds; LoginView prefill-once; populatedBuckets unique ForEach id; Format rounding rollover; dead-code/docstring/dedup cleanups. Verification pending on the Mac (no Swift toolchain on the Linux dev box). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
8de962eeb8
commit
203465913c
21 changed files with 303 additions and 103 deletions
|
|
@ -14,7 +14,7 @@ final class ONURepository {
|
|||
|
||||
/// Fetch every ONU state, paging through with the `next` cursor.
|
||||
func allStates() async throws -> [ONUStateDoc] {
|
||||
try await client.getAll(.onuStates, idOf: { $0.id })
|
||||
try await client.getAll(.onuStates, idOf: { $0.documentId })
|
||||
}
|
||||
|
||||
func configs(query: APIQuery = .empty) async throws -> [ONUConfigDoc] {
|
||||
|
|
@ -26,7 +26,7 @@ final class ONURepository {
|
|||
func nameMap() async throws -> [String: String] {
|
||||
var query = APIQuery()
|
||||
query.projection = ["ONU.Name": 1]
|
||||
let configs: [ONUConfigDoc] = try await client.getAll(.onuConfigs, baseQuery: query, idOf: { $0.id })
|
||||
let configs: [ONUConfigDoc] = try await client.getAll(.onuConfigs, baseQuery: query, idOf: { $0.documentId })
|
||||
return configs.reduce(into: [:]) { map, config in
|
||||
if let name = config.name, !name.isEmpty { map[config.id] = name }
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue