Svorka/PONGo_ios
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Apply code-review fixes: identity/pagination, load races, TLS pin, leaks

Browse source 
Addresses a multi-agent code review (26 confirmed findings + a URLSession
leak) across correctness, concurrency, security, and cleanup:

- MongoDocument.id: deterministic fallback (was UUID() on every access) to stop
  SwiftUI List/ForEach identity churn; getAll pagination drives its cursor off
  the real _id via documentId, so a missing _id stops paging instead of looping
  on a fabricated cursor.
- View models: per-load generation guard (+ captured-tab guard on ONU detail)
  so a cancelled or overlapping load can't commit stale results or land data on
  the wrong tab.
- JSONValue.intValue: guard Int(d) against NaN/inf/out-of-range (crash).
- ServerTrustEvaluator: hash the real SubjectPublicKeyInfo (prepend the
  algorithm-specific ASN.1 SPKI header) so a standard openssl-captured
  public-key pin actually matches; unknown key types fail closed.
- AppEnvironment.configure: clear stale cookies + Keychain creds on host change.
- FirmwareFile.isCompatible: empty metadata no longer passes as compatible-for-all.
- APIClient: invalidate URLSession on deinit (per-configure/probe leak).
- Dashboard best-effort sections keep last-good on transient failure; unified
  optical thresholds; LoginView prefill-once; populatedBuckets unique ForEach id;
  Format rounding rollover; dead-code/docstring/dedup cleanups.

Verification pending on the Mac (no Swift toolchain on the Linux dev box).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jon Vanvik 2026-05-31 16:36:49 +02:00
parent 8de962eeb8
commit 203465913c
21 changed files with 303 additions and 103 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Firmware.swift
View file

@ -6,7 +6,7 @@ struct FirmwareFile: MongoDocument {
init(from decoder: Decoder) throws { raw = try JSONValue(from: decoder) }
init(raw: JSONValue) { self.raw = raw }
var id: String { raw["_id"]?.stringValue ?? filename ?? UUID().uuidString }
var id: String { raw["_id"]?.stringValue ?? filename ?? raw.compactDescription }
var filename: String? { raw["filename"]?.stringValue ?? raw["_id"]?.stringValue }
var version: String? { raw["metadata"]?["Version"]?.stringValue }
var manufacturer: String? { raw["metadata"]?["Compatible Manufacturer"]?.stringValue }
@ -14,14 +14,19 @@ struct FirmwareFile: MongoDocument {
var sizeBytes: Double? { raw["length"]?.doubleValue }
var uploadDate: String? { raw["uploadDate"]?.stringValue }
/// True when this image targets the given ONU: manufacturer matches the ONU
/// vendor AND the ONU's equipment id is one of the compatible models (exact,
/// case-insensitive — substring matching would wrongly pass e.g. an
/// "XGS2110" image for an "FTXGS2110B" ONU).
/// True only when this image POSITIVELY targets the given ONU: manufacturer
/// matches the ONU vendor (when both are known) AND the ONU's equipment id is
/// one of the compatible models (exact, case-insensitive — substring matching
/// would wrongly pass e.g. an "XGS2110" image for an "FTXGS2110B" ONU).
///
/// An image with NO declared compatibility metadata (empty manufacturer/models),
/// or when the ONU's equipment id is unknown, is treated as NOT compatible — for
/// a destructive flash, an un-typed image must be chosen deliberately via the
/// sheet's "Show all" escape hatch rather than appearing as compatible-for-all.
func isCompatible(vendor: String?, equipmentId: String?) -> Bool {
if let vendor, let manufacturer, !manufacturer.isEmpty,
manufacturer.caseInsensitiveCompare(vendor) != .orderedSame { return false }
guard let equipmentId, !models.isEmpty else { return true }
guard let equipmentId, !models.isEmpty else { return false }
return models.contains { $0.caseInsensitiveCompare(equipmentId) == .orderedSame }
}
}