Enabling R8 in the previous commit surfaced two build issues; fixed here so
assembleDebug AND assembleRelease both succeed (verified on this machine:
Android Studio JBR 21 + SDK android-36).
- proguard-rules.pro: add `-dontwarn com.google.errorprone.annotations.**`.
Tink (pulled in by androidx.security-crypto / EncryptedSharedPreferences)
references compile-only Error Prone annotations that aren't on the runtime
classpath, which R8 treated as fatal "missing class" errors.
- ApiClient.await(): @OptIn(ExperimentalCoroutinesApi::class) for the
resume(value){ onCancellation } overload (experimental in coroutines 1.8.1).
Release APK is R8-shrunk (~1.8 MB vs ~18 MB debug). It is unsigned — wire a
signing config / keystore (kept out of VCS) before distributing.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Outcome of a full multi-agent code review. Touches TLS, credential storage,
API versioning, networking correctness, concurrency/lifecycle, and the release
build. See CHANGELOG.md for the full list and the items to port to the iOS app.
Security
- Remove untrusted-TLS support: delete ServerTrustPolicy.AllowSelfSignedForHost
and its trust-all X509TrustManager; drop the self-signed Settings toggle.
- Enforce HTTPS in normalizedBaseUrl (reject http + embedded credentials);
add network_security_config (no cleartext, system CAs only) + allowBackup=false.
- Never persist passwords at rest: remember-me stores email only; no password
pre-fill; clear creds on sign-out / when remember-me is off.
- Match CSRF host lookup to OkHttp's host parsing; stop leaking raw exception text.
Correctness
- Fix API versioning: hardcode v1/v3 per endpoint (docs Sec.4) instead of one
broken global apiVersion; remove the version plumbing + Settings field.
- Treat "warning" status as success (committed write); fail-fast on a missing
pagination cursor; close Response on cancellation; tolerant JSON parse; User-Agent.
- Firmware isCompatible fails closed + extra acknowledgment for a non-compatible image.
Concurrency / lifecycle
- Run network I/O on Dispatchers.IO; stale-result generation guards + rethrow
CancellationException in all loads; host AppState in a ViewModel (survive config
change); thread-safe cookie jar; reset/upgrade re-entry guard; wire list Retry.
Build
- Enable R8 minify+shrink with kotlinx.serialization keep rules; drop unused
navigation-compose; add the missing .gitignore.
NOTE: built/verified by static review only (no Android SDK on the dev machine) —
run :app:assembleDebug and a release build before shipping.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
